[ENH] Standardize and organize entity descriptions #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
added
the
schema
tsalo
requested review from
Remi-Gau and
sappelhoff
and removed request for
erdalkaraca
Codecov Report
@@ Coverage Diff @@
## master #1264 +/- ##
=======================================
Coverage 87.95% 87.95%
=======================================
Files 6 6
Lines 1038 1038
=======================================
Hits 913 913
Misses 125 125 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sappelhoff
reviewed
Aug 31, 2022
Co-authored-by: Stefan Appelhoff <[email protected]>
Remi-Gau
approved these changes
Sep 1, 2022
sappelhoff
approved these changes
Sep 1, 2022
|
thanks @tsalo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes None. I was starting to work on #612 and #1194, when I realized that the actual entity definitions could be improved.
My main goal was to make the link between entities and metadata fields clearer.