[FIX] Clarify MEG empty-room recommendations #1125
Conversation
robertoostenveld
requested review from
agramfort,
alexrockhill,
dnacombo,
ftadel,
guiomar and
tiborauer
|
I'm very happy that we finally adopt this practice. While creating the specs many years ago this idea (i.e. having the associated empty rooms inside each subjects folder, when recorded especifically for each subject/session) was discarted, and I felt this produced a folder structure and code to match these files that was unnecessarily complicated. For example, we experienced that while organizing the OMEGA repository with hundreds of participants many of them with multiple sessions, and each of them with a emptyroom recording that was dumped into the emptyroom subject mixing them up and making it less intuitive. @ftadel @Moo-Marc @rcassani I tag you here in case we finally merge this PR, so you are aware for the brainstorm BIDS importer and reorganization of the OMEGA dataset. |
I have added a exampe. - Shall it be named task-noise, or task-emptyroom? - Shall it be named sub-control01 (as it will be past of this subject) or sub-emptyroom (eventhough it's inside sub-control01)? Please edit as you see
There was a problem hiding this comment.
Hi all,
I also agree with clarifying the two approaches. @guiomar, I had already decided to switch OMEGA to putting noise recordings into individual subject folders, after this discussion. Regarding your second example, yes I think it should be sub-control01 and task-noise.
Do we want to comment on the possibility of mixing the two approaches? It could be useful in a large repository mixing data from various sources, or if a lab does both approaches. The daily recordings could be used by a lab tech, and the subject-specific ones for analysis. If we allow it, we could merge the two examples.
|
Yes @Moo-Marc I think it would be a good idea that the two approaches could be merged together |
There was a problem hiding this comment.
This seems very reasonable +1 from me.
If you have 100 subjects and 50 empty room sessions with 2 subjects collected on each day, is there a way not to duplicate each empty room session twice? Maybe to use the Example 1 method but add an empty_ses tag to the task data in a sidecar (rest in the example)? Or is the best solution to just store the duplicate? And, if so, can you make a symbolic link and still have it pass BIDS? As I'm writing this, I'm thinking that answers to these questions might be nice to have in the specification also.
But then we'd have an ambiguity if both are present. Which one should a software implementation load? |
At NeuroSpin, we've done it such that when you convert the freshly recorded data to BIDS, basically everything would be symlinks, so you could "duplicate" stuff a million times if you wanted to and still wouldn't run out of disk space :) We use the Also makes the conversion much faster ;) |
That sounds nice and related to this. I know symlinks are probably mentioned other places in the BIDS spec but my 2 cents would be that it's nice having the recommended strategy all in the same place. |
|
My proposal is to keep this pull request as just a small clarification of the current text without any extensions to it. It is possible to come up with further improvements for empty room data, but I think that would better be a separate PR that follows this. |
Absolutely, this was just a bit of an off-topic discussion :) |
instead it is now a recommendation to associate the data to an empty-room recording.
- example 1: one per day in sub-emptyroom - example 2: one per session, along with normal subject and session
robertoostenveld
requested review from
dnacombo,
ftadel,
guiomar,
sappelhoff and
alexrockhill
sappelhoff
changed the title
There is now the sentence "In the context of BIDS it is RECOMMENDED to associate an empty-room recording to each experimental session". That would indeed work by specifying |
Co-authored-by: Richard Höchenberger <[email protected]>
Co-authored-by: Richard Höchenberger <[email protected]>
Actually the same question as @dnacombo's popped up in my head while reading the draft. I figured that we're essentially getting rid of AssociatedEmptyRoom here. Seems I was mistaken. This confusion among @dnacombo and me seems to suggest the text still needs a bit of polishing..? |
|
... also because AssociatedEmptyRoom happens on a per-run and not on a per-session level ... at least that's how I added it to my metadata so far. |
|
can you make a suggested edit to clarify it? |
I can try tonight, currently I'm only on my phone :) |
|
Thanks all, this looks good to me. Regarding the "In the context of BIDS it is RECOMMENDED to associate an empty-room recording to each experimental session (see Adjusting or removing the link as required - I'm not sure what's the convention. |
Co-authored-by: Richard Höchenberger <[email protected]>
|
Thanks everyone |
@mcvinding noted to me that the recommendation for empty-room MEG recordings was confusing, as it confounds two practices.
Some labs record an empty-room recording every morning to be shared, that is then to be used for all subjects/sessions recorded during that day.
Other labs record an empty-room recording prior to each experimental session, those are not shared.
The text specified that it is "RECOMMENDED to perform an empty-room recording for each experimental session" (i.e., non -shared) and subsequently it explained how to organize the daily shared empty-room recordings in a
sub-emptyroom/ses-YYYYMMDDstructure.The updated text splits the two and does not prescribe the recommended
ses-YYYYMMDDpractice for empty-room recordings done prior to each experimental session, as those are more logically shared with the actual subject and session.