[FIX] cleaner handling of missing dependency #473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes: added a test if file referenced by IntendedFor field is indexed (if
isempty(info_dest.file_idx)
).Now it produces warning (if verbose) and skips the file:
Removed the try/catch introduced in #471 as it may hide possible bugs and blame input datasets.
This try/catch can be re-introduced, but I feel it must protect full
manage_dependencies
function.Making request draft, as there an alternative implementation of the fix #474.