Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] cleaner handling of missing dependency #473

Merged
merged 3 commits into from
Nov 11, 2022

Conversation

nbeliy
Copy link
Collaborator

@nbeliy nbeliy commented Nov 9, 2022

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes: added a test if file referenced by IntendedFor field is indexed (if isempty(info_dest.file_idx)).
Now it produces warning (if verbose) and skips the file:

Warning: IntendedFor file /Storage/beliy/bidsifications/osf/source/sub-01/fmap/sub-01_acq-headMTw_RB1COR.json from sub-01_magnitude1.nii not indexed

Removed the try/catch introduced in #471 as it may hide possible bugs and blame input datasets.

This try/catch can be re-introduced, but I feel it must protect full manage_dependencies function.

Making request draft, as there an alternative implementation of the fix #474.

@Remi-Gau Remi-Gau changed the title Fix for the issue #470 [FIX] cleaner handling of missing dependency Nov 11, 2022
@Remi-Gau
Copy link
Collaborator

closes #470

I have a preference for this one if only because all the tests pass out of the box.

@Remi-Gau Remi-Gau marked this pull request as ready for review November 11, 2022 08:05
Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks @nbeliy

@Remi-Gau Remi-Gau merged commit 97a29a9 into bids-standard:master Nov 11, 2022
@nbeliy nbeliy deleted the nb_470 branch November 14, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants