Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed error messages #30

Merged
merged 1 commit into from
Dec 22, 2019
Merged

More detailed error messages #30

merged 1 commit into from
Dec 22, 2019

Conversation

apjanke
Copy link
Collaborator

@apjanke apjanke commented Dec 21, 2019

Here's a suggestion for more detailed error messages. This mostly involves including the actual problematic values in error messages, including a specific reason/underlying error message for a failure, or telling which BIDS file/dir it was trying to process when the error occurred. This will make it easier for users to diagnose errors when using BIDS-MATLAB.

It also switches to using the catch <err> syntax where appropriate. This syntax is supported by all Matlab and Octave versions indicated in #22, and is more concise than calling lasterror().

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@Remi-Gau Remi-Gau merged commit 9bce439 into bids-standard:master Dec 22, 2019
@apjanke apjanke deleted the more-detailed-error-messages branch December 23, 2019 20:01
@apjanke
Copy link
Collaborator Author

apjanke commented Dec 23, 2019

👍

Remi-Gau added a commit that referenced this pull request Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants