-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first draft of general conventions page #26
Merged
effigies
merged 18 commits into
bids-standard:main
from
PeerHerholz:general_conventions
Nov 27, 2023
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
cc7f8e9
first draft of general conventions page
PeerHerholz 005d4de
Update docs/general_conventions.md
PeerHerholz 9866692
Update docs/general_conventions.md
PeerHerholz 1eb757f
Update docs/general_conventions.md
PeerHerholz 4f5b373
Update mkdocs.yml
PeerHerholz fe3de8c
Rename general_conventions.md to general_guidelines.md
PeerHerholz 88fe9d4
Update docs/general_guidelines.md
PeerHerholz c8d7e26
Update docs/general_guidelines.md
PeerHerholz 965a9cc
Update docs/general_guidelines.md
PeerHerholz d287cc5
Update docs/general_guidelines.md
PeerHerholz e1ef67e
Update docs/general_guidelines.md
PeerHerholz e810d4a
Update docs/general_guidelines.md
PeerHerholz 8b85b15
Update docs/general_guidelines.md
PeerHerholz 7d27b36
Update docs/general_guidelines.md
PeerHerholz 834a291
Merge branch 'main' into general_conventions
PeerHerholz 64202c3
Update docs/general_guidelines.md
PeerHerholz 2dd9a79
update general_guidelines.md
PeerHerholz 894e46b
Update docs/general_guidelines.md
PeerHerholz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
# BEP general guidelines | ||
|
||
Based on the evergrowing set of `BEP`s and the respective work and efforts conducted to develop them, the community has identified a set of general guidelines that can be used to guide the corresponding processes. | ||
These guidelines are not part of the [BIDS specification](https://bids-specification.readthedocs.io/en/stable/index.html), but rather are recommended to be followed when developing a `BEP`. | ||
These guidelines are not set in stone and can be modified as needed. | ||
These guidelines are RECOMMENDED. | ||
The goal is to establish a basis of consensus to ease agile approval of `BEP`s that propose terms in line with these guidelines. | ||
|
||
## Facilitate atomic changes | ||
|
||
See [issue #371](https://github.com/bids-standard/bids-specification/issues/371) for motivation and discussion. | ||
It is recommended to identify perspective entities and metadata fields to be added, and research if they, or their synonyms, are already considered in submitted PRs or other BEPs. | ||
If those are new, propose a PR(s) introducing those to the BIDS schema so that | ||
- they could be reviewed "independently" of the larger BEP | ||
- potentially be made aware of in other BEPs | ||
|
||
## Formulate "BEP specific guidelines" | ||
|
||
If multiple BEPs need coordination, this document (section below) could be used to formulate guidelines for specific aspects to be followed by multiple BEPs. | ||
|
||
## General guidelines for spatial derivatives | ||
|
||
Within this section, guidelines for developing `BEP`s that include spatial derivatives are outlined and motivated. | ||
|
||
### Problem statement | ||
|
||
During the work on multiple `BEP`s that include `spatial derivatives`, a repeated pattern in generating derivatives within several imaging modalities' workflows was identified where: | ||
|
||
1. A reference map that is used to encode spatial features and parameters is required. | ||
There is an antecedent of this in `BIDS` with BEP23 ([see below](#BEP-23-PET-Derivatives)). | ||
In that `BEP`, the proposed naming takes the pattern `_<suffix>ref` (e.g., `_boldref`, `_dwiref`, etc.), and that solution has been suggested as a possibility in [issue #1532](https://github.com/bids-standard/bids-specification/issues/1532) of the spec repository. | ||
|
||
2. We have derived data that are no longer of the same type as the original, but for which we would like to keep the notion of the modality from which this was derived while also signaling that it is derived (i.e., `non-raw`). | ||
|
||
### Motivation for guidelines | ||
|
||
Many users are not equipped to understand fine distinctions between different classes of derivatives (e.g., those that are produced by a `model fit and` a `direct computation`). | ||
|
||
### Guidelines | ||
|
||
A specific suffix *pattern* is used : `_<suffix>map`, where `<suffix>` is a BIDS suffix used in the `raw` data (e.g., `dwi` or `bold`). | ||
For example, the proposed pattern produces the suffices `_dwimap` or `_boldmap`. | ||
`BEP`s may use this suffix pattern under the conditions specified below and MUST specify the extension and metadata that are required with the suffix. | ||
|
||
1. The file descriptor does fall under one of the generic derivatives descriptors. | ||
2. No other descriptor exists in the `BIDS` spec. | ||
For example, `statmap` cannot be used, because it is already being used, or soon to be, for a [different specification](https://bids-standard.github.io/stats-models/walkthrough-1.html#from-run-outputs-to-subject-inputs). | ||
|
||
This suffix pattern provides context through the concatenation of a raw data suffix and the word "`map`", which implies that the file still contains spatially contiguous information (in contrast to tabular/"tidy" data, with each row representing a brain region, for example). | ||
|
||
This pattern is, in principle, generalizable across `BEP`s and derivatives in general: | ||
|
||
1. A data process might have generated primary parameters that are either `3D (x,y,z)` or `4D (x,y,z,v)`. | ||
These parameters might be of help for further data analysis or data interpretation, and ultimately the data end user. Examples include "statistics" such as mean, std, etc., or model derivatives, such as `DTI FA`. | ||
|
||
2. At the same time, the process might have generated secondary parameters. | ||
These are not strictly necessary for further processing or data interpretation, but they can be potentially useful to interpret the outputs of the data process, to track history of the processing, for reproducibility and ultimately for debugging purposes of the developer/modeler of the code. | ||
|
||
### Examples | ||
|
||
#### BEP 23: PET Derivatives | ||
|
||
`BEP 23` has introduced Molecular Imaging Maps "`mimap`s" that correspond to the conventions introduced by `BEP 001 (qMRI)`, such as `T1map`, `T2map`, etc. | ||
|
||
These generally will be distributed as mean/standard-deviation pairs, for example: `sub-01_stat-mean_desc-5HT_mimap.nii.gz`/`sub-01_stat-std_desc-5HT_mimap.nii.gz`. | ||
|
||
#### BEP 12: Functional MRI derivatives | ||
|
||
`BEP 12` proposes a collection of summary statistics, including `mean`, `standard deviation`, `temporal SNR`, `regional homogeneity`, etc. | ||
Following the example of `BEP 23`, it has adopted the proposal. | ||
|
||
* `<source_entities>_stat-<mean|std|...>_boldmap.nii.gz` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps who or how to keep track of other PRs and BEPs would be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about the BEP leads are responsible for this and the maintainers verify?