-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spherical coordinates & 3-vectors: Fill value #72
Comments
Commenting here rather than in a code-linked comment thread in #90 for better separation of concepts & provenance. Initially in #90 the demand of zero-filling was added in 5dd412c. However this demand was repeated in multiple instances, as there are multiple data representations that may necessitate the use of filling. b336fa6 changes the required fill value to be NaN. However the intent of my comment was perhaps a little broader:
|
Have added |
For these two representations, the number of volumes in the 4D image must be set based on the maximal number of fixels in any voxel. This means that many voxels may have less than this number of fixels. The specification needs to state what data should be present in the image in such cases.
For 3-vectors and spherical coordinates that include an amplitude term, zero-filling is moderately safe, but only if the measure being encoded in the amplitude can be reasonably interpreted as "0 == absent", which may not be the case in all circumstances. For spherical coordinates without amplitudes, no such capability exists.
I think I would advocate that any absent fixels should be NaN-filled, regardless of representation.
The text was updated successfully, but these errors were encountered: