Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] rerunning the app overrides old files and logs a warning #83

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

Remi-Gau
Copy link
Collaborator

closes #76

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Merging #83 (1aa04d2) into main (321705e) will increase coverage by 0.71%.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   91.45%   92.17%   +0.71%     
==========================================
  Files          10       10              
  Lines         480      473       -7     
==========================================
- Hits          439      436       -3     
+ Misses         41       37       -4     
Files Coverage Δ
giga_connectome/workflow.py 90.19% <100.00%> (ø)
giga_connectome/utils.py 94.66% <50.00%> (+4.42%) ⬆️

@Remi-Gau Remi-Gau changed the title [ENH] rerunning the app overrides old files and log a warning [ENH] rerunning the app overrides old files and logs a warning Dec 14, 2023
Copy link
Collaborator

@htwangtw htwangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@htwangtw htwangtw merged commit 241b2a3 into bids-apps:main Dec 14, 2023
15 checks passed
@Remi-Gau Remi-Gau deleted the overwrite branch December 15, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a rerun of the app should overwrite previous results
3 participants