Show asterisks for password

bhrutledge · Sep 25, 2021 · f60db37 · f60db37
1 parent 28d8571
commit f60db37
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/tests/test_repository.py b/tests/test_repository.py
@@ -352,7 +352,9 @@ def test_package_is_uploaded_incorrect_repo_url():
     [
         (None, None, ["username: <empty>", "password: <empty>"]),
         ("", "", ["username: <empty>", "password: <empty>"]),
-        ("username", "password", ["username: username", "password: <hidden>"]),
+        ("username", "password", ["username: username", "password: ********"]),
+        # Ctrl-V in Windows Command Prompt; see https://bugs.python.org/issue37426
+        ("username", "\x16", ["username: username", "password: *"]),
     ],
 )
 def test_logs_username_and_password(username, password, messages, caplog):

diff --git a/twine/repository.py b/twine/repository.py
@@ -65,7 +65,7 @@ def __init__(
             (username or "", password or "") if username or password else None
         )
         logger.info(f"username: {username if username else '<empty>'}")
-        logger.info(f"password: <{'hidden' if password else 'empty'}>")
+        logger.info(f"password: {'*' * len(password) if password else '<empty>'}")
 
         self.session.headers["User-Agent"] = self._make_user_agent_string()
         for scheme in ("http://", "https://"):