Modern animation system #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear the target data before pushing new vertices and faces
Provide a clone method to the specialized geometries in src/extras/geometry, otherwise: - the `.parameters` are not copied - the `.type` of the clone is "Geometry" or "BufferGeometry" - the cloned object is not an instance of the initial type. It loses its specialization and becomes a plain `Geometry` or `BufferGeometry`. Class deriving from `PolyhedronGeometry` defined `this.parameters` all over the place. Standardize to defining the `.type` and `.parameters` after the `PolyhedronGeometry` constructor is called. Also fix prototype inheritance chain for classes deriving from `PolyhedronGeometry`.
Add more geometries to ObjectLoader.js and pass down missing parameters to constructors for `CircleGeometry` and `CylinderGeometry`.
- Parameterized geometry (e.g. BoxGeometry) should not clone the base properties of Geometry. - CubeTexture: Clone is parameterless.
Covers construction, cloning, json import/export. Use lodash from npm.
- reverts back to the original text, removing any mention about setPixelRatio - adds information about how to render an app at lower resolution using updateStyle - replaces mentions of "game" with "app"
corrects missleading information in "creating a scene" example
… skeleton instead...
make sure uniforms don't get loaded when they are not in the shader
OrbitControls takes care of the DOM, input binding and event handling. OrbitConstraint is responsible for keeping the camera on an orbit, maintaining its orientation towards the target and updating the camera and target position. There is only one insignificant API change. Before, dolly / rotate functions could be called without parameters to engage autoRotate / autoSpeed. OrbitConstraint does not support that. Now, OrbitControls must provide these parameter explicitly to OrbitConstraint. As far as I can tell, those methods were only used internally and should not be part of the control API. OrbitControls extends OrbitConstraint. In my ideal implementation, OrbitConstraint should be a property of the OrbitControls, but using inheritence help preserve the existing interface. OrbitConstraint is not included in the `THREE` namespace. It is defined in a closure and private to this file. It could also the placed in `extras\constraints`, along with other contraints that could be extracted from the current controls, and maybe other type of constraints on the object position/displacement (constrain movement to plane, to path, collision). These constraints should not necessarily be limited to cameras; they could apply to any objects. It's not clear to me how all this will shape up, but this is a nice place to pause and ask for feedback before going forward.
… interoplation required.
bhouston
pushed a commit
that referenced
this pull request
Jul 20, 2016
* Update index.html * Revert "Update index.html" This reverts commit 76f4786. * added options for gammaInput and gammaOutput * added storage for gammaInput and gammaOutput * added gammaInOut values to json export * further adds added gammaInOutput options to the app and fixed them not loading on page reload * dang that was wrong
bhouston
pushed a commit
that referenced
this pull request
Mar 15, 2017
Update webgl_geometry_shapes.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.