Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated pydicom.dicomdir.DicomDir variable type option #130

Merged
merged 3 commits into from
Oct 23, 2024
Merged

fix: remove deprecated pydicom.dicomdir.DicomDir variable type option #130

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ea5202
fix: remove deprecated pydicom.dicomdir.DicomDir variable type option
strixy16 Oct 23, 2024
d19c2bd
style: removed Union since dicom_data can only be a FileDataset
strixy16 Oct 23, 2024
e000fb7
refactor: remove Union import for linting
strixy16 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/imgtools/utils/dicomutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def get_modality_metadata(dicom_data, modality: str):
return metadata


def all_modalities_metadata(dicom_data: Union[pydicom.dataset.FileDataset, pydicom.dicomdir.DicomDir]) -> Dict[str, T]:
def all_modalities_metadata(dicom_data: pydicom.dataset.FileDataset) -> Dict[str, T]:
metadata = get_modality_metadata(dicom_data, 'ALL')

if hasattr(dicom_data, 'PixelSpacing') and hasattr(dicom_data, 'SliceThickness'):
Expand Down
Loading