Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added pages from med-imagenet to disciplines/Imaging #86

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JoshuaSiraj
Copy link

@JoshuaSiraj JoshuaSiraj linked an issue Nov 12, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

Hi there @JoshuaSiraj! 👋

This PR Title does not meet the Conventional Commits specification.

Add a prefix to indicate what kind of release this pull request corresponds to.
Common Types:

  • feat: A new feature | Adding a Page/Section to the Handbook
  • fix: A bug fix | Fixing a typo in the Handbook
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • perf: A code change that improves performance
  • build: Changes that affect the build system or external dependencies (example: Adding a dependency to Pixi)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files

Please Edit the PR Title to prepend the prefix to your PR:
[prefix]: Added pages from med-imagenet to disciplines/Imaging

@JoshuaSiraj JoshuaSiraj changed the title Added pages from med-imagenet to disciplines/Imaging feat: Added pages from med-imagenet to disciplines/Imaging Nov 12, 2024
@jjjermiah jjjermiah marked this pull request as draft November 12, 2024 19:07
@JoshuaSiraj JoshuaSiraj marked this pull request as ready for review November 26, 2024 14:58
function of an anatomic region, typically presented as an array of picture
elements called **pixels** (2D) or **voxels** (3D). This representation is a
discrete mapping of **numerical values** to positions in space.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to add the diagram

- **Pixel depth**: Bytes used to represent each voxel intensity
- **Data type**: Integer, floating-point, etc.

*add diagram showing a sample header with key metadata fields*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to add the diagram


\[
\text{Image File Size} = \text{Header Size} + \text{Pixel Data Size}
\]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it's a markdown formatting issue, but it isn't clear what you're speaking about here or what this refers to

| Pixel Depth | 2 bytes (16-bit image) |
| Number of Frames | 32 (32 slices) |

\[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the markdown for this equation also doesn't show up properly

- **Two Files**: Metadata and image data stored separately.
- **Example**: Analyze (.hdr and .img)

*add diagram comparing single file vs. two-file configurations*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget the diagram

<https://nipy.org/nibabel/coordinate_systems.html>
<https://nipy.org/nibabel/nifti_images.html>
NIFTI first poster: <https://nifti.nimh.nih.gov/nifti-1/documentation/hbm_nifti_2004.pdf>
NIfTI structure diagram: <https://nifti.nimh.nih.gov/nifti-1/documentation/nifti1diagrams_v2.pdf>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

descriptor and link are not in the same line; if you could add a description to what this is supposed to show, would be useful

Copy link
Contributor

@fpvyas fpvyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very comprehensive and easy to understand! just needs some minor formatting fixes

@jjjermiah jjjermiah marked this pull request as draft November 27, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

Imaging Basics
2 participants