Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Callgrind instead of Cachegrind #26

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

madsmtm
Copy link

@madsmtm madsmtm commented Feb 20, 2022

Quick draft, willing to put the work in to making this PR prettier if this transition desired, @bheisler?

Using Callgrind makes the output even more stable, since we no longer need to do an initial calibration run, so any setup that the OS linker has to perform is never included in the output. This is especially important when using valgrind on macOS (see #25 (comment)), since the linker does more work at runtime there.

See Callgrind docs for more info.

Could also be part of fixing #7, #20 and #23.

@madsmtm
Copy link
Author

madsmtm commented Feb 22, 2022

Idea: Use the callgrind crate or similar to send "client requests" to Valgrind instead of the blunt --toggle-collect that this PR uses now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant