Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unknown doc attribute Hidden at nightly #17

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Fix unknown doc attribute Hidden at nightly #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ pub enum Error {
column: usize,
},

#[doc(Hidden)]
#[doc(hidden)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that's what I'm fixing. Is there a problem with the cache on the CI?

Copy link

@paolobarbolini paolobarbolini Mar 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a problem with the cache on the CI?

criterion is being used as a dev-dependency, and it's importing this crate from crates.io.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, there is a cyclic dependency.

But this is a criterion bug nightly so it should be fixed from the criterion repository. From here I can't do anything. Remove dependency, little more.

It's just in the benchmarks I don't think it's important.

__NonExhaustive,
}
impl From<SerdeJsonError> for Error {
Expand Down