Make multimethods public, check for explicit problem type #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry to hit you up for a release, but I'm going to try and release my spell-spec library https://github.com/bhauman/spell-spec so I can start using it in |
bhauman
reviewed
May 28, 2018
src/expound/alpha.cljc
Outdated
| @@ -381,6 +381,9 @@ | |||
|
|
|||
| (defn ^:private problem-type [failure problem] | |||
| (cond | |||
| (:expound.spec.problem/type problem) | |||
There was a problem hiding this comment.
The above should probably be
(when-let [typ (:expound.spec.problem/type problem)]
(get-method expound/problem-group-str typ))
to ensure that the problem type is supported.
If not fallback to expounds normal behavior.
There was a problem hiding this comment.
otherwise an error will be thrown for an unsupported type
|
@bhauman Thanks for the help here. I'm hoping to get some time to do a release tonight, or failing that, tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opens to door to allowing external libraries to control how expound prints problems from other types of specs.
I'd like to refine the extensibility for expound for the eventual beta version, but hopefully this will work in a pinch.