Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression of #3 #183

Closed
vemv opened this issue Dec 30, 2019 · 4 comments
Closed

Regression of #3 #183

vemv opened this issue Dec 30, 2019 · 4 comments
Labels

Comments

@vemv
Copy link
Contributor

vemv commented Dec 30, 2019

Hey there again,

I just tried upgrading [expound "0.7.2"] -> [expound "0.8.3"].

But my cljs tests started failing with that, with the same exact error that the #3 OP attaches: Cannot read property 'cljs$lang$applyTo' of undefined.

I could fix it by adding #?(:cljs [goog.string.format]) in my codebase, just like 131d86c does.

However, the issue itself is a regression, thought it'd be worth informing of it to you.

Can attach a repro if needed but this one seems straightforward.

Cheers - V

@vemv vemv mentioned this issue Dec 30, 2019
28 tasks
@bhb
Copy link
Owner

bhb commented Dec 30, 2019

Thanks for reporting this! It's unfortunate the tests didn't catch this mistake. It looks like I broke this in 22655c1

@bhb bhb added the bug label Dec 30, 2019
@bhb
Copy link
Owner

bhb commented Dec 31, 2019

@vemv Out of curiosity, are you testing on an older version of CLJS? I am just curious because I can repro with

clojure -Sdeps '{:deps {org.clojure/clojurescript {:mvn/version "1.10.439"} expound {:mvn/version "0.8.3"}}}' -m cljs.main -re node -e "(require '[expound.alpha :as expound]) (expound.alpha/expound int? 5.6)"

but not

clojure -Sdeps '{:deps {org.clojure/clojurescript {:mvn/version "1.10.514"} expound {:mvn/version "0.8.3"}}}' -m cljs.main -re node -e "(require '[expound.alpha :as expound]) (expound.alpha/expound int? 5.6)"

(or any version newer than 1.10.514)

Regardless, this is still a bug I will fix.

@vemv
Copy link
Contributor Author

vemv commented Dec 31, 2019

I'm using org.clojure/clojurescript "1.10.597"

Thanks for the fix!

@bhb
Copy link
Owner

bhb commented Jan 1, 2020

@vemv Thanks again for reporting this. Fixed in 0.8.4

@bhb bhb closed this as completed Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants