-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression of #3 #183
Comments
Thanks for reporting this! It's unfortunate the tests didn't catch this mistake. It looks like I broke this in 22655c1 |
@vemv Out of curiosity, are you testing on an older version of CLJS? I am just curious because I can repro with
but not
(or any version newer than Regardless, this is still a bug I will fix. |
I'm using Thanks for the fix! |
@vemv Thanks again for reporting this. Fixed in |
Hey there again,
I just tried upgrading [expound "0.7.2"] -> [expound "0.8.3"].
But my cljs tests started failing with that, with the same exact error that the #3 OP attaches:
Cannot read property 'cljs$lang$applyTo' of undefined
.I could fix it by adding
#?(:cljs [goog.string.format])
in my codebase, just like 131d86c does.However, the issue itself is a regression, thought it'd be worth informing of it to you.
Can attach a repro if needed but this one seems straightforward.
Cheers - V
The text was updated successfully, but these errors were encountered: