Skip to content

Commit

Permalink
Remove superfluous DegreeOfMatrixGroup method
Browse files Browse the repository at this point in the history
DegreeOfMatrixGroup is a synonym for DimensionOfMatrixGroup -- that means they
are actually identical. Installing an operation as a method for itself will cause a segfault
if that method ever is invoked Luckily, for attribute storing reps (which currently is used
by all our matrix groups), that method never gets invoked anyway precisely because the
two attributes are identical: if HasDimensionOfMatrixGroup(G) gives true, then the system
getter (which has a very high rank) is used to retrieve the value.

Still, it seems best to remove this.
  • Loading branch information
fingolfin authored and bh11 committed Apr 24, 2021
1 parent b18293b commit e860ee1
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions lib/matmeths.gi
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@ InstallMethod(DegreeOfMatrixGroup, "for matrix group with dimension", true,
Dimension);


InstallMethod(DegreeOfMatrixGroup, "for matrix group with dimension", true,
[IsMatrixGroup and HasDimensionOfMatrixGroup], 0,
DimensionOfMatrixGroup);


############################################################################
##
#M IsIrreducible(<G>)
Expand Down

0 comments on commit e860ee1

Please sign in to comment.