Fixed SSH client key validation #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strings.HasPrefix() call was used with flipped argument order, allowing incomplete rows in the authorized_keys file to any key matching that prefix. In worst case, a line like ecdsa-sha2-nistp256 with no key at all would match all keys of that type. On the other hand, when the key was followed by a comment as is common in authorized_keys files, it wasn't matched at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
strings.HasPrefix()call was used with flipped argument order, allowing to match incomplete rows in theauthorized_keysfile to any key matching that prefix. In worst case, a line likeecdsa-sha2-nistp256with no key at all would match all keys of that type.
On the other hand, when the key was followed by a comment (or anything else) as is common in
authorized_keysfiles, it wasn't matched at all.