-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grace period for diff #70
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "testing" | ||
| "time" | ||
|
|
||
| log "github.com/sirupsen/logrus" | ||
|
|
||
| "github.com/bgp/stayrtr/prefixfile" | ||
| ) | ||
|
|
||
| func TestBuildNewVrpMap_expiry(t *testing.T) { | ||
| stuff := testData() | ||
| now := time.Now() | ||
| log := log.WithField("client", "TestBuildNewVrpMap_expiry") | ||
|
|
||
| res, inGracePeriod := BuildNewVrpMap(log, make(VRPMap), stuff, now) | ||
| if inGracePeriod != 0 { | ||
| t.Errorf("Initial build does not have objects in grace period") | ||
| } | ||
|
|
||
| _, inGracePeriodPreserved := BuildNewVrpMap(log, res, []prefixfile.VRPJson{}, now.Add(time.Minute*10)) | ||
| if inGracePeriodPreserved != len(res) { | ||
| t.Errorf("All objects are in grace period") | ||
| } | ||
|
|
||
| // Objects are kept in grace period | ||
| // 1s before grace period ends | ||
| t1 := now.Add(*GracePeriod).Add(-time.Second * 1) | ||
| res, inGracePeriod = BuildNewVrpMap(log, res, []prefixfile.VRPJson{}, t1) | ||
|
|
||
| assertLastSeenMatchesTimeCount(t, res, t1, 0) | ||
| assertLastSeenMatchesTimeCount(t, res, now, len(stuff)) | ||
| if inGracePeriod != len(stuff) { | ||
| t.Errorf("All objects should be in grace period. Expected: %d, actual: %d", len(stuff), inGracePeriod) | ||
| } | ||
|
|
||
| // 1s after grace period ends, they are removed | ||
| res, inGracePeriod = BuildNewVrpMap(log, res, []prefixfile.VRPJson{}, now.Add(*GracePeriod).Add(time.Second*1)) | ||
| if len(res) != 0 { | ||
| t.Errorf("Expected no objects to be left after grace period, actual: %d", len(res)) | ||
| } | ||
| if inGracePeriod != 0 { | ||
| t.Errorf("Expected 0 objects in grace period, actual: %d", inGracePeriod) | ||
| } | ||
| } | ||
|
|
||
| func TestBuildNewVrpMap_firsSeen_lastSeen(t *testing.T) { | ||
| t0 := time.Now() | ||
| log := log.WithField("client", "TestBuildNewVrpMap_firstSeen_lastSeen") | ||
| stuff := testData() | ||
|
|
||
| var res, _ = BuildNewVrpMap(log, make(VRPMap), stuff, t0) | ||
|
|
||
| // All have firstSeen + lastSeen equal to t0 | ||
| assertFirstSeenMatchesTimeCount(t, res, t0, len(stuff)) | ||
| assertLastSeenMatchesTimeCount(t, res, t0, len(stuff)) | ||
|
|
||
| // Supply same data again later | ||
| t1 := t0.Add(time.Minute * 10) | ||
| res, _ = BuildNewVrpMap(log, res, stuff, t1) | ||
|
|
||
| // FirstSeen is constant, LastSeen gets updated | ||
| assertFirstSeenMatchesTimeCount(t, res, t0, len(stuff)) | ||
| assertLastSeenMatchesTimeCount(t, res, t1, len(stuff)) | ||
|
|
||
| // Supply one new VRP, expect one at new time, others at old time | ||
| otherStuff := []prefixfile.VRPJson{ | ||
| { | ||
| Prefix: "2001:DB8::/32", | ||
| Length: 48, | ||
| ASN: 65536, | ||
| TA: "testrir", | ||
| }, | ||
| } | ||
| t2 := t1.Add(time.Minute * 10) | ||
| res, _ = BuildNewVrpMap(log, res, otherStuff, t2) | ||
|
|
||
| // LastSeen gets updated just for the new item | ||
| assertFirstSeenMatchesTimeCount(t, res, t0, len(stuff)) | ||
| assertLastSeenMatchesTimeCount(t, res, t1, len(stuff)) | ||
|
|
||
| assertFirstSeenMatchesTimeCount(t, res, t2, len(otherStuff)) | ||
| assertLastSeenMatchesTimeCount(t, res, t2, len(otherStuff)) | ||
| } | ||
|
|
||
| func assertFirstSeenMatchesTimeCount(t *testing.T, vrps VRPMap, pit time.Time, expected int) { | ||
| actual := countMatches(vrps, func(vrp *VRPJsonSimple) bool { return vrp.FirstSeen == pit.Unix() }) | ||
| if actual != expected { | ||
| t.Errorf("Expected %d VRPs to have FirstSeen of %v, actual: %d", expected, pit, actual) | ||
| } | ||
| } | ||
|
|
||
| func assertLastSeenMatchesTimeCount(t *testing.T, vrps VRPMap, pit time.Time, expected int) { | ||
| actual := countMatches(vrps, func(vrp *VRPJsonSimple) bool { return vrp.LastSeen == pit.Unix() }) | ||
| if actual != expected { | ||
| t.Errorf("Expected %d VRPs to have LastSeen of %v, actual: %d", expected, pit, actual) | ||
| } | ||
| } | ||
|
|
||
| type extractor func(object *VRPJsonSimple) bool | ||
|
|
||
| func countMatches(vrps VRPMap, e extractor) int { | ||
| matches := 0 | ||
| for _, entry := range vrps { | ||
| if e(entry) { | ||
| matches++ | ||
| } | ||
| } | ||
|
|
||
| return matches | ||
| } | ||
|
|
||
| func testData() []prefixfile.VRPJson { | ||
| var stuff []prefixfile.VRPJson | ||
| stuff = append(stuff, | ||
| prefixfile.VRPJson{ | ||
| Prefix: "192.168.0.0/24", | ||
| Length: 24, | ||
| ASN: 65537, | ||
| TA: "testrir", | ||
| }, | ||
| prefixfile.VRPJson{ | ||
| Prefix: "192.168.0.0/24", | ||
| Length: 24, | ||
| ASN: 65536, | ||
| TA: "testrir", | ||
| }, | ||
| prefixfile.VRPJson{ | ||
| Prefix: "2001:db8::/32", | ||
| Length: 33, | ||
| ASN: "AS64496", | ||
| TA: "testrir", | ||
| }, | ||
| prefixfile.VRPJson{ | ||
| Prefix: "192.168.1.0/24", | ||
| Length: 25, | ||
| ASN: 64497, | ||
| TA: "testrir", | ||
| }, | ||
| ) | ||
|
|
||
| return stuff | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just skimming really and no expert in Golang either.
Is there a way to set this GracePeriod via configuration file?