Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index page to rtrmon #69

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

ties
Copy link
Collaborator

@ties ties commented Jul 11, 2022

I added documentation as the HTML index page instead of a 404. Since the rtrmon endpoints are not used often it is hard to remember the URL of the diff endpoint. In the end a user needs to document this in internal documentation - or go to the rtrmon docs while investigating an alert.

I think adding this here is a small quality of life feature for users.

In my opinion the templating is optional, but it is definitely slightly nicer.
Screenshot 2022-07-11 at 12 17 49

@ties ties requested a review from job July 11, 2022 10:20
@job job merged commit 3df8c24 into bgp:master Jul 11, 2022
@ties ties deleted the feature/add-index-page-to-rtrmon branch July 11, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants