Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #66 - Display bhr markers #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolves #66 - Display bhr markers #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion js/histogram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,10 +512,11 @@ var HistogramContainer;
// markers are combined if they are at the same time
var lastMarkerTime = -1;
if (this.markers) {
const MARKER_TYPES_TO_DISPLAY = ["stack", "bhr"];
for (var j = 0; j < this.markers.length; j++) {
var marker = this.markers[j];
// ignore markers that have data/category (waterfall markers)
if (marker.type == "stack" || !marker.data || !marker.data.category && marker.name != "gpu_timer_query") {
if (MARKER_TYPES_TO_DISPLAY.includes(marker.type) || !marker.data || !marker.data.category && marker.name != "gpu_timer_query") {
// if the previous first marker of a set and this marker are
// within the same pixel, combine them
if (lastMarkerTime != -1 && (lastMarkerTime + 5*step / barWidth > marker.time)) {
Expand Down