Skip to content

Commit

Permalink
Fix setup.py install with old setuptools
Browse files Browse the repository at this point in the history
We still need to support building distro packages with older setuptools
that doesn't understand PEP 621.  Re-add enough setup.py configuration
(duplicating pyproject.toml) to make older setuptools happy.

Signed-off-by: Benjamin Gilbert <[email protected]>
  • Loading branch information
bgilbert committed Oct 30, 2024
1 parent 56c0b55 commit 512ddc0
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 0 deletions.
19 changes: 19 additions & 0 deletions .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,25 @@ jobs:
path: artifacts/whl
compression-level: 0

setuptools:
name: Setuptools install
needs: pre-commit
runs-on: ubuntu-20.04
steps:
- name: Check out repo
uses: actions/checkout@v4
- name: Install dependencies
run: |
sudo apt-get update
sudo apt-get install -y libopenslide0 python3-pil
pip install pytest
- name: Install OpenSlide Python
run: sudo python setup.py install
- name: Run tests
run: pytest -v
- name: Tile slide
run: python examples/deepzoom/deepzoom_tile.py --viewer -o tiled tests/fixtures/small.svs

docs:
name: Docs
needs: pre-commit
Expand Down
20 changes: 20 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
import os
import sys

from setuptools import Extension, setup

# Load version string
_verfile = os.path.join(os.path.dirname(__file__), 'openslide', '_version.py')
with open(_verfile) as _fh:
exec(_fh.read()) # instantiates __version__

# use the Limited API on Python 3.11+; build release-specific wheels on
# older Python
_abi3 = sys.version_info >= (3, 11)
Expand All @@ -21,4 +27,18 @@
# tag wheel for Limited API
'bdist_wheel': {'py_limited_api': 'cp311'} if _abi3 else {},
},
#
# setuptools < 61 compatibility for distro packages building from source
name='openslide-python',
version=__version__, # type: ignore[name-defined] # noqa: F821
install_requires=[
'Pillow',
],
packages=[
'openslide',
],
package_data={
'openslide': ['py.typed', '*.pyi'],
},
zip_safe=False,
)

0 comments on commit 512ddc0

Please sign in to comment.