Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge #968

Merged
merged 2 commits into from
Sep 13, 2024
Merged

merge #968

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74d319c
fix bucket worker not waiting for all queue worker to finish
burgalon Sep 13, 2024
e004a1e
Merge pull request #967 from burgalon/fix-bucket-worker-bug
bghira Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion helpers/metadata/backends/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,11 @@ def compute_aspect_ratio_bucket_indices(self, ignore_existing_cache: bool = Fals
ncols=100,
miniters=int(len(new_files) / 100),
) as pbar:
while any(worker.is_alive() for worker in workers):
while any(worker.is_alive() for worker in workers) or \
not tqdm_queue.empty() or \
not aspect_ratio_bucket_indices_queue.empty() or \
not metadata_updates_queue.empty() or \
not written_files_queue.empty():
current_time = time.time()
while not tqdm_queue.empty():
pbar.update(tqdm_queue.get())
Expand Down
Loading