Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve security by not reading files #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve security by not reading files #4

wants to merge 1 commit into from

Conversation

bgaillard
Copy link
Owner

@bgaillard bgaillard commented Dec 20, 2023

As mentioned in #3 versions 1.0.0 and 1.0.1 of the plugin prevented plugins to be triggered with auto-complete actions (i.e. while editing text) but not when a file was opened.

This PR changes how the plugin works to secure files even more by simply not reading them.

⚠️ The PR is currently in "work-in-progress", see the todo list bellow to know what work still needs to be be done before merging it.

TODO

  • Remove the secured_files option
  • Describe in the README.md file how to use the patterns and add links to the Neovim documentation for those who need details and more "complex" configurations
  • Create a content for the readonly buffer with the exact Neovim command to call to open the file securely
  • Explain how the plugin works in the README.md file
  • Update the CHANGELOG.md file

@bgaillard bgaillard self-assigned this Dec 20, 2023
@bgaillard bgaillard force-pushed the issue-3 branch 2 times, most recently from 6b543fa to da003b3 Compare December 20, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant