update e2e testing doc to direct user to enable adminserver tls #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MikeEdgar, I'm not confident on this one 😁 is this script used to run against environments where there is an https admin route? |
Why: The tests assume an https route to the adminserver is available by default
robobario
force-pushed
the
e2e-test-http-admin
branch
from
c808697 to
6d958ca
Compare
robobario
changed the title
|
Have changed to a README update after Mike showed us how to enable tls on the adminserver |
k-wall
approved these changes
Oct 7, 2022
MikeEdgar
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
On a kas-installer OSD cluster the e2e tests were failing with the config generated by this script because there was no https route to the admin service.