Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check OBSERVABILITY_CONFIG_ACCESS_TOKEN can be used to access the con… #219

Merged

Conversation

robobario
Copy link
Contributor

…fig repo

Why:
An expired github personal access token causes a failure late in the deployment, we can make it explode early.

@robobario robobario force-pushed the observability-token-fail-fast branch from 56c8619 to b85d9c3 Compare September 11, 2022 22:54
kas-installer.sh Outdated Show resolved Hide resolved
@robobario robobario force-pushed the observability-token-fail-fast branch from b85d9c3 to f8e0a01 Compare September 13, 2022 21:37
Copy link
Contributor

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Would you mind rebasing before merge? I did so locally to try it out, there are a few commits since this PR was opened.

@robobario robobario force-pushed the observability-token-fail-fast branch from f8e0a01 to 87ad4f3 Compare September 27, 2022 22:03
…fig repo

Why:
An expired github personal access token causes a failure late in the
deployment, we can make it explode early.
@robobario robobario merged commit cdce8c6 into bf2fc6cc711aee1a0c2a:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants