Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump Observability Operator version to v4.0.0 #1423

Merged

Conversation

vmanley
Copy link
Contributor

@vmanley vmanley commented Dec 2, 2022

Description

Bump the version of Observability Operator to v4.0.0

Verification Steps

Checklist (Definition of Done)

  • All acceptance criteria specified in JIRA have been completed
  • Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer
  • All PR comments are resolved either by addressing them or creating follow up tasks
  • Required metrics/dashboards/alerts have been added (or PR created).
  • Required Standard Operating Procedure (SOP) is added.
  • JIRA has been created for changes required on the client side

@github-actions github-actions bot added documentation Improvements or additions to documentation kafka service-template Label categorizing all the service templates changes labels Dec 2, 2022
@pb82
Copy link
Contributor

pb82 commented Dec 5, 2022

@vmanley I don't think this needs to be a draft. Let's get v3.0.16 on stage before the next Prod release.

Copy link
Contributor

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.

Can we follow suit with this one by bumping https://github.com/bf2fc6cc711aee1a0c2a/kas-installer/blob/main/kas-installer-defaults.env#L127 to the latest tag that contains this change as well as updating https://github.com/bf2fc6cc711aee1a0c2a/kas-installer/blob/main/kas-installer-defaults.env#L145 to match the latest KFM commit sha? Thanks

@machi1990 machi1990 marked this pull request as ready for review December 5, 2022 16:03
@machi1990 machi1990 requested a review from a team as a code owner December 5, 2022 16:03
@machi1990
Copy link
Contributor

@vmanley I don't think this needs to be a draft.

+1 I've promoted the PR to get CI run.

Let me know if this is waiting on anything else or it can be merged if we've a green CI run? @vmanley

@vmanley vmanley force-pushed the bump-obs-operator-version branch from c67c81b to d01f186 Compare December 5, 2022 16:49
@vmanley vmanley changed the title feat: bump Observability Operator version to v3.0.16 feat: bump Observability Operator version to v4.0.0 Dec 5, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1423 (d01f186) into main (58d4336) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1423   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files         143      143           
  Lines       12794    12794           
=======================================
  Hits        10659    10659           
  Misses       1753     1753           
  Partials      382      382           
Flag Coverage Δ
unittests 83.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../kafka/internal/config/dataplane_cluster_config.go 68.58% <ø> (ø)

@vmanley
Copy link
Contributor Author

vmanley commented Dec 5, 2022

@pb82 @machi1990 Bumped to v4.0.0. Verified on cluster. Could I get one of you to merge?

Copy link
Contributor

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I'd also like @pb82 to give his blessings on this.
Please lets also followup in updating kas-installer

@machi1990 machi1990 merged commit 752566e into bf2fc6cc711aee1a0c2a:main Dec 6, 2022
@vmanley vmanley deleted the bump-obs-operator-version branch December 6, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation kafka service-template Label categorizing all the service templates changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants