Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial fix for placement #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

valpuia
Copy link

@valpuia valpuia commented Apr 9, 2024

partial fix for #90

Another problem: If I use Placement::TopRight then the noti/account and lang-swith are place on top of each other (only on profile page) like this image
Screenshot from 2024-04-09 11-24-00

I cannot run/install tailwind and it's dependencies because of below error (but I don't know how to fix for now) so I cannot check more. Bezhan, as you said in discord I've submitted this PR in order to look further from you

The error
Screenshot from 2024-04-09 11-46-51

My guess for fixing this is to put like this

<div @class([
    ...
    '-right-5' => str_contains($outsidePanelsPlacement, 'top-right') // may need to check if it's profile cause others are working fine
])>

If this PR is not the right fix then feel free to close it

Copy link

what-the-diff bot commented Apr 9, 2024

PR Summary

  • Modification of language-switch.blade.php File
    • The design of a specific section of our website, managed by the div element in language-switch.blade.php file, has been updated. The sizing of this section has been changed to ensure it uses the full width available, improving our site's layout.
    • Also, the vertical placement of certain elements (governed by top-0 and bottom-0 classes) will now adapt to the user’s settings (outsidePanelsPlacement) for enhanced user experience.
    • Furthermore, the alignment of these elements (controlled by justify-start class) will also be conditioned by user preferences (outsidePanelsPlacement), adding more customization possibilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant