Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix register-middleware #14

Merged
merged 1 commit into from
Nov 26, 2022
Merged

fix register-middleware #14

merged 1 commit into from
Nov 26, 2022

Conversation

medeiroz
Copy link
Contributor

Problem

Service provider works in a different way for laravel serve and laravel octane
laravel serve to register service provider everytime. because each request do a complete bootstrap.
But octane once time (on startup application).

The middleware should be register once time on bootstrap application

Solution

Moved the register middleware to ServiceProvider

Notes

I tested with laravel serve and laravel octane with and without register migration on config/filament.php

@bezhanSalleh bezhanSalleh merged commit 8ed1c5d into bezhanSalleh:main Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants