Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max height to language switch dropdown #100

Merged

Conversation

michaelklopf
Copy link
Contributor

We would like to add the functionality to set the max height of the dropdown. Because when you have a lot of languages you can't scroll through the list anymore

It currently looks like this
image

and like this with the PR
Bildschirmfoto 2024-06-18 um 09 44 54

Copy link

what-the-diff bot commented Jun 18, 2024

PR Summary

  • Introduction of $maxHeight variable
    A new variable called $maxHeight is introduced in the language-switch.blade.php file. This plays a key role in controlling the maximum height property of certain elements in our application.

  • Usage of :max-height attribute
    The newly introduced $maxHeight variable is utilized as a :max-height attribute in the switch.blade.php file. This allows us better control over the visual aspects as it defines the maximum height of an element.

  • Added functionality in LanguageSwitch.php
    Included a new property, protected string $maxHeight = 'max-content';, and a new function public function maxHeight(string $height): static to the LanguageSwitch.php file. This further extends the customization capabilities of our language switch feature, enabling it to adjust to different sizes based on input from the $maxHeight variable.

@bezhanSalleh bezhanSalleh merged commit 827b20f into bezhanSalleh:main Nov 21, 2024
1 check passed
@bezhanSalleh
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants