-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Google Auth #26
Upgrade Google Auth #26
Conversation
Once people are happy with the implementation then I will look at updating the documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few improvements for readability and a question
Note that we don't validate the jwt signature, so it might be better to get rid of the new dependency and just bade64 decode the unencrypted part of the jwt |
Certainly if you're happy with having the suggested browser function in the codebase. I'll update this |
Removed |
lets pnpm link this to the app to try it first before we merge and release. |
👋🏻 Hey, just getting back to this today. I've done a decent amount of testing and reading through our internal use-cases. @antony with minor changes to our login screen I've got this working as we would expect. I've exposed the whole token through the It's worth noting the GSI does not like running on non-https domains, other than localhost, so this will throw some complications for us and potentially other development workflows. |
I've also noticed that :global(.social-auth-button button) {
width: 100%;
font-family: 'Cabin', sans-serif;
border-radius: 5px;
} But I don't think this is anything to do with this pull request as looking at the code I have not changed anything relating to styles. |
Thanks for the PR! I installed from this commit and importing failed, but copying over the GoogleAuth.svelte file and using it like any other component seems to work :) |
lets also consider this #14 when we merge |
Resolves #25
Upgrades from using
gapi.auth2
togoogle.accounts.id
(https://developers.google.com/identity/gsi/web).This change, however, is breaking as the outputs from the events are different.
auth-success
now returns an object with user properties:name
email
picture
auth-failure
now returns a basic stringinit-error
is no longer used