[rfc]: added proxy support via proxy-agent #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sadly node has not added proxy support to its core yet (nodejs/node#15620) so it is necessary to implement it in each client lib -.-
i added proxy support to via https://github.com/TooTallNate/node-proxy-agent to your awesome lib.
i haven't added tests yes and i am not sure about correctly updating the
package-lock.json
(had not worked on a node module before). is it just anpm install
required to generate the correct lock file or is there something special for a node module?also i am not quite happy with the mixed type variable (boolean/object), i thought about
empty object
,object
andundefined
references:
edit: not really an idea how to test this.
edit2: as proxyagent should work transparent, maybe using it could be the default