Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

GSP-93: Add ObjectMode Pair #93

Merged
merged 4 commits into from
Jun 8, 2021
Merged

GSP-93: Add ObjectMode Pair #93

merged 4 commits into from
Jun 8, 2021

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Jun 8, 2021

Signed-off-by: Xuanwo [email protected]

@Xuanwo Xuanwo marked this pull request as draft June 8, 2021 04:07
@Xuanwo Xuanwo linked an issue Jun 8, 2021 that may be closed by this pull request
Xuanwo added 3 commits June 8, 2021 12:21
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo marked this pull request as ready for review June 8, 2021 04:24
@Xuanwo Xuanwo requested review from JinnyYi, Prnyself and xxchan June 8, 2021 04:24
@Xuanwo Xuanwo changed the title Proposal: Add ObjectMode Pair GSP-93: Add ObjectMode Pair Jun 8, 2021
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jun 8, 2021

ping @Prnyself to give me another LGTM.

Copy link
Member

@Prnyself Prnyself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo Xuanwo merged commit c10a5e6 into master Jun 8, 2021
@Xuanwo Xuanwo deleted the object_mode_pair branch June 8, 2021 06:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: Create should accept ObjectMode
3 participants