This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
GSP-137: Service Output Template #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
5 tasks
xxchan
reviewed
Jul 7, 2021
Comment on lines
+18
to
+22
| If service provider specify `output_template` to `%s_test.go`, `definitions` will generate files into: | ||
|
|
||
| - `generated_test.go` | ||
| - `service_test.go` | ||
| - `storage_test.go` |
There was a problem hiding this comment.
service.go and storage.go are formatted, not generated?
xxchan
reviewed
Jul 7, 2021
|
|
||
| [Increase code coverage](https://github.com/beyondstorage/go-storage/issues/620) plans to move `cmd/definitions/tests` into `tests` and support generating files into `generate_test.go` so we won't export test services. | ||
|
|
||
| So `definitions` should have the ability to generate all files into a specified output filename template. |
There was a problem hiding this comment.
Do we actually need this feature in definitions? If we just want to change tests, we can simply write some scripts in Makefile?
There was a problem hiding this comment.
Do we actually need this feature in
definitions? If we just want to changetests, we can simply write some scripts inMakefile?
You are right. The feature is used in tests services only. I will abort this GSP and use scripts instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xuanwo [email protected]