docs: Add iterator docs for go-storage #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <[email protected]>
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/beyondstorage/site/DPCFCFAt6MXMP3Pbi3ZNoo7jkZZ4 |
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
bokket
reviewed
Aug 10, 2021
Signed-off-by: Xuanwo <[email protected]>
bokket
reviewed
Aug 10, 2021
| - In `nextObjectPageByDir`: | ||
| - Don't use the `for` loop, our iterator already handles it. | ||
| - Don't read the whole list, this will consume too much memory. | ||
| - Don't store returned slices in `objectPageStatus`, handle and parse them directly to `page.Data`. |
There was a problem hiding this comment.
Similarly for counting the number of files we don't need to, because we have iterator for next.
objectPageStatusonly needs to store information about directories and files, the rest is optional
JinnyYi
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #95
Signed-off-by: Xuanwo [email protected]