Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(services/s3): Support absolute path and idempotent delete #937

Merged
merged 4 commits into from
Oct 24, 2021

Conversation

JinnyYi
Copy link
Contributor

@JinnyYi JinnyYi commented Oct 21, 2021

ref: #860

@Xuanwo
Copy link
Contributor

Xuanwo commented Oct 21, 2021

Oh, minio has documented this behavior:

https://github.com/minio/minio/blob/master/cmd/fs-v1-multipart.go#L801-L804

// Implements S3 compatible Abort multipart API, slight difference is
// that this is an atomic idempotent operation. Subsequent calls have
// no affect and further requests to the same uploadID would not be
// honored.

Maybe we can refer them too.

GitHub
High Performance, Kubernetes Native Object Storage - minio/fs-v1-multipart.go at master · minio/minio

services/s3/utils.go Outdated Show resolved Hide resolved
services/s3/utils.go Outdated Show resolved Hide resolved
@Xuanwo Xuanwo merged commit 68c10ce into master Oct 24, 2021
@Xuanwo Xuanwo deleted the issue-860 branch October 24, 2021 08:49
@Xuanwo
Copy link
Contributor

Xuanwo commented Oct 24, 2021

Oh, the comment of our logic should be updated via minio/minio#13495 (reply in thread)

AWS S3 is inconsistent in its behavior, it returns 404 after 24hours.

@JinnyYi Can you create an issue to track it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants