Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

definitions: Deprecate Reacher and expire #734

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Conversation

JinnyYi
Copy link
Contributor

@JinnyYi JinnyYi commented Sep 2, 2021

ref: #731

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #734 (d155d2c) into master (56d461e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   12.47%   12.47%           
=======================================
  Files          22       22           
  Lines        1483     1483           
=======================================
  Hits          185      185           
  Misses       1291     1291           
  Partials        7        7           
Flag Coverage Δ
unittests 12.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/generated.go 2.22% <ø> (ø)
types/operation.generated.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d461e...d155d2c. Read the comment docs.

@Xuanwo
Copy link
Contributor

Xuanwo commented Sep 2, 2021

Maybe we also need to deprecate expire?

@JinnyYi JinnyYi changed the title definitions: Deprecate Reacher definitions: Deprecate Reacher and expire Sep 2, 2021
@Xuanwo Xuanwo merged commit ba30a03 into master Sep 2, 2021
@Xuanwo Xuanwo deleted the deprecate-reacher branch September 2, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants