Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/definitions: Implement GSP-725 Add Defaultable Property for Pair #730

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

JinnyYi
Copy link
Contributor

@JinnyYi JinnyYi commented Aug 30, 2021

ref: #727

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #730 (a33768e) into master (46f8633) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
- Coverage   12.55%   12.50%   -0.06%     
==========================================
  Files          22       22              
  Lines        1473     1479       +6     
==========================================
  Hits          185      185              
- Misses       1281     1287       +6     
  Partials        7        7              
Flag Coverage Δ
unittests 12.50% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/generated.go 2.22% <0.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f8633...a33768e. Read the comment docs.

@@ -51,6 +51,7 @@ type = "bool"

[pairs.storage_class]
type = "string"
defaultable = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like WithDefaultStorageClass is not generated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been generated in https://github.com/beyondstorage/go-storage/pull/730/files#diff-d872ad7215a358bcc5ae66b3577ab2db501f7f8497ac6624e7374a19b7f69fedR88. We pointed it as a defaultable pair in namespace before, so we can't find it in this change.

@Xuanwo Xuanwo merged commit 1530ebb into master Aug 31, 2021
@Xuanwo Xuanwo deleted the gsp-725 branch August 31, 2021 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants