-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use gg to generate code for pairs #728
Conversation
Signed-off-by: Xuanwo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
=======================================
Coverage 12.47% 12.47%
=======================================
Files 22 22
Lines 1483 1483
=======================================
Hits 185 185
Misses 1291 1291
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Xuanwo <[email protected]>
ping @JinnyYi to take another look. |
I will extend it to more complex functions like |
Signed-off-by: Xuanwo <[email protected]>
I re-design the API of codegen that inspired by The code can't be compiled so fat, I will implement it if it looks good. |
I think it‘s easy to read and translate into the final generated code. |
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
ping @JinnyYi for review. |
LGTM. Only a small doubt, is it possible or necessary to keep only |
Yes, we have to. We use |
I will bump a version about gg, please merge this PR after update, thanks! |
Signed-off-by: Xuanwo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This is a demo PR for evaluations.
Related to #607.