Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSP-706: Support HTTP Signer #706

Merged
merged 5 commits into from
Aug 17, 2021
Merged

GSP-706: Support HTTP Signer #706

merged 5 commits into from
Aug 17, 2021

Conversation

JinnyYi
Copy link
Contributor

@JinnyYi JinnyYi commented Aug 16, 2021

ref: #646

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #706 (a38f002) into master (f14e890) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #706   +/-   ##
=======================================
  Coverage   12.35%   12.35%           
=======================================
  Files          22       22           
  Lines        1441     1441           
=======================================
  Hits          178      178           
  Misses       1256     1256           
  Partials        7        7           
Flag Coverage Δ
unittests 12.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14e890...a38f002. Read the comment docs.

@JinnyYi JinnyYi changed the title GSP: Support Signed URL GSP-706: Support Signed URL Aug 16, 2021
docs/rfcs/706-support-signed-url.md Outdated Show resolved Hide resolved
docs/rfcs/706-support-signed-url.md Outdated Show resolved Hide resolved
docs/rfcs/706-support-signed-url.md Outdated Show resolved Hide resolved
@JinnyYi JinnyYi changed the title GSP-706: Support Signed URL GSP-706: Support HTTP Signer Aug 16, 2021
@Xuanwo Xuanwo merged commit 348ecf7 into master Aug 17, 2021
@Xuanwo Xuanwo deleted the signed-url branch August 17, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants