Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPFS example #12

Merged
merged 4 commits into from
Jul 22, 2021
Merged

Add IPFS example #12

merged 4 commits into from
Jul 22, 2021

Conversation

zu1k
Copy link
Member

@zu1k zu1k commented Jul 9, 2021 •
edited
Loading

@zu1k zu1k requested a review from JinnyYi July 15, 2021 02:29
JinnyYi
JinnyYi reviewed Jul 15, 2021
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 15, 2021

Oooops, missing github.com/beyondstorage/go-storage/v4/pkg/endpoint breaks a lot, we will fix it.

@zu1k
Copy link
Member Author

zu1k commented Jul 15, 2021

v4.3.1 still has problems, better update the dependencies of these services

# github.com/beyondstorage/go-service-cos/v2
go\pkg\mod\github.com\beyondstorage\go-service-cos\[email protected]\generated.go:47:13: o.GetServiceMetadata undefined (type *types.Object has no field or method GetServiceMetadata)
go\pkg\mod\github.com\beyondstorage\go-service-cos\[email protected]\generated.go:60:3: o.SetServiceMetadata undefined (type *types.Object has no field or method SetServiceMetadata)
# github.com/beyondstorage/go-service-fs/v3
go\pkg\mod\github.com\beyondstorage\go-service-fs\[email protected]\generated.go:37:13: o.GetServiceMetadata undefined (type *types.Object has no field or method GetServiceMetadata)
go\pkg\mod\github.com\beyondstorage\go-service-fs\[email protected]\generated.go:50:3: o.SetServiceMetadata undefined (type *types.Object has no field or method SetServiceMetadata)
# github.com/beyondstorage/go-service-s3/v2
go\pkg\mod\github.com\beyondstorage\go-service-s3\[email protected]\generated.go:51:13: o.GetServiceMetadata undefined (type *types.Object has no field or method GetServiceMetadata)
go\pkg\mod\github.com\beyondstorage\go-service-s3\[email protected]\generated.go:64:3: o.SetServiceMetadata undefined (type *types.Object has no field or method SetServiceMetadata)

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 15, 2021

Yep, the service also needs a release.

I have to admit remove pkg/endpoint and ServiceMetadata too quickly is a mistake. We will start a GSP to forbid behavior like this, and a huge break like this time will not happen again.

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 15, 2021

ping @JinnyYi, can you help release all our services after upgrading to v4.3.1?

@JinnyYi
Copy link
Contributor

JinnyYi commented Jul 15, 2021

ping @JinnyYi, can you help release all our services after upgrading to v4.3.1?

OK.

@JinnyYi
Copy link
Contributor

JinnyYi commented Jul 22, 2021

@zu1k The dependent services have been updated. You can merge beyondstorage:master into your work branch to continue with the next step.

@zu1k zu1k requested a review from JinnyYi July 22, 2021 08:45
@Xuanwo Xuanwo merged commit 8f5d2b5 into beyondstorage:master Jul 22, 2021
@Xuanwo Xuanwo mentioned this pull request Jul 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@JinnyYi JinnyYi Awaiting requested review from JinnyYi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zu1k @Xuanwo @JinnyYi