This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Settings and helper functions implemented with some interfaces #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Aug 16, 2021
| panic("not implemented") | ||
| } | ||
|
|
||
| func (s *Storage) read(ctx context.Context, path string, w io.Writer, opt pairStorageRead) (n int64, err error) { | ||
| panic("not implemented") | ||
| buckets := s.project.ListBuckets(ctx, nil) |
There was a problem hiding this comment.
Why do we need to ListBuckets before DownloadObject?
|
Please fix the conflict. |
|
Hello, any updates here? |
|
I am busy these weekdays therefore no big progress. I will work on this
project full time during weekend to finish on time.
Xuanwo ***@***.***>于2021年8月27日 周五16:26写道：
… Hello, any updates here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHFZVKRWK2ED7N3BD3GW3NTT65D4RANCNFSM5CGFZHMQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Xuanwo
reviewed
Aug 30, 2021
| @@ -1,11 +1,13 @@ | |||
| name = "storj" | |||
|
|
|||
| [namespace.storage] | |||
| implement = ["copier", "mover", "direr"] | |||
There was a problem hiding this comment.
How remove all these implement so that we can focus on implementing Storager?
| @@ -7,7 +7,25 @@ import ( | |||
| . "github.com/beyondstorage/go-storage/v4/types" | |||
| ) | |||
|
|
|||
| func (s *Storage) copy(ctx context.Context, src string, dst string, opt pairStorageCopy) (err error) { | |||
There was a problem hiding this comment.
Let's implement them further.
|
Hello, what's your next schedule? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose storj-uplink as the lib. However, I found myself lacking background knowledge of go-storage. Therefore, this pr has some errors to be improved in the later work.