Skip to content
This repository has been archived by the owner on Oct 15, 2021. It is now read-only.

ci: Add dependabot go-storage auto build support #139

Merged
merged 4 commits into from
Jul 14, 2021
Merged

ci: Add dependabot go-storage auto build support #139

merged 4 commits into from
Jul 14, 2021

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Jul 14, 2021

Signed-off-by: Xuanwo [email protected]

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Jul 14, 2021

ping @xxchan for a look.

There are the following problems:

- The action won't work until we set go-storage to semver: Dependabot ignore git versions

  • I don't know how to test this workflow.

Comment on lines +2 to +6
on: pull_request_target

permissions:
pull-requests: write
contents: write
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on: pull_request_target
permissions:
pull-requests: write
contents: write
on: pull_request

is enough?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need Auto commit & push, so write is required.

@xxchan
Copy link
Contributor

xxchan commented Jul 14, 2021

I think we can test by removing dependency-names first?

@xxchan
Copy link
Contributor

xxchan commented Jul 14, 2021

Wait, but we have to merge this into master first to test?

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Jul 14, 2021

Wait, but we have to merge this into master first to test?

Yep, it's a problem. Maybe we can merge this to another branch?

Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Jul 14, 2021

Here is an open PR from dependabot: #138

Maybe we can test via them instead.

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Jul 14, 2021

Wait, but we have to merge this into master first to test?

Yep, it's a problem. Maybe we can merge this to another branch?

I think this is an affordable price: one or two useless commit

@xxchan
Copy link
Contributor

xxchan commented Jul 14, 2021

Maybe we can merge this to another branch?

Can it be triggered? I'm OK.

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Jul 14, 2021

image

Ooops, it looks like we have to merge this PR into master first.

@xxchan xxchan merged commit f1856d9 into master Jul 14, 2021
@xxchan xxchan deleted the go-storage branch July 14, 2021 06:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants