Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

feat: Set up integration tests #21

Merged
merged 23 commits into from
Aug 31, 2021
Merged

feat: Set up integration tests #21

merged 23 commits into from
Aug 31, 2021

Conversation

bokket
Copy link
Member

@bokket bokket commented Aug 27, 2021

Signed-off-by: bokket [email protected]

readdir_test.go Outdated Show resolved Hide resolved
readdir_test.go Outdated Show resolved Hide resolved
readdir_test.go Outdated
Comment on lines 40 to 42
if err != nil {
t.Error(err)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

readdir_test.go Outdated
Comment on lines 49 to 51
if err != nil {
t.Error(err)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto (or assert.NoError)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly for code below

bokket added 4 commits August 28, 2021 10:32
Signed-off-by: bokket <[email protected]>
Signed-off-by: bokket <[email protected]>
Signed-off-by: bokket <[email protected]>
@Xuanwo
Copy link
Contributor

Xuanwo commented Aug 28, 2021

I think it's a bug in setup-hdfs: https://github.com/beyondstorage/setup-hdfs/pull/36/checks?check_run_id=3450465739

I will try to fix it tomorrow.

@Xuanwo
Copy link
Contributor

Xuanwo commented Aug 28, 2021

Hello, I fixed this problem in beyondstorage/setup-hdfs#36, please test it again:

steps:
  - uses: actions/setup-python@v2
    with:
      python-version: '3.8'
  - uses: actions/setup-java@v1
    with:
      java-version: '11'

  - uses: beyondstorage/setup-hdfs@master
    with:
      hdfs-version: '3.3.1'

  - run: curl ${{ env.HDFS_NAMENODE_ADDR }}

@Xuanwo
Copy link
Contributor

Xuanwo commented Aug 28, 2021

Ops, let's test on linux only for now.

- name: Setup-hdfs env
uses: beyondstorage/setup-hdfs@master
with:
hdfs-version: '3.3.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can test on more supported versions like:

  • "2.10.1"
  • "2.2.2"
  • "3.3.0"
  • "3.3.1"

Copy link
Member Author

@bokket bokket Aug 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to add more versions, just like:
hdfs: [ "2.10.1", "2.2.2", "3.3.0", "3.3.1"],but look like failure :)
It just had the wrong version number.I have fixed it.
"2.2.2"--->"3.2.2"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about sending a PR to setup-hdfs to fix it?

.github/workflows/intergration-test.yml Outdated Show resolved Hide resolved
.github/workflows/unit-test.yml Outdated Show resolved Hide resolved
utils_test.go Outdated Show resolved Hide resolved
utils_test.go Outdated Show resolved Hide resolved
storager_test.go Outdated Show resolved Hide resolved
@Xuanwo Xuanwo changed the title feat:Add utils and readdir test feat: Set up integration tests Aug 30, 2021
bokket added 4 commits August 30, 2021 17:58
Signed-off-by: bokket <[email protected]>
Signed-off-by: bokket <[email protected]>
Signed-off-by: bokket <[email protected]>
@Xuanwo
Copy link
Contributor

Xuanwo commented Aug 31, 2021

Starting namenodes on [localhost]
localhost: Host key verification failed.
localhost: Host key verification failed.
Starting secondary namenodes [0.0.0.0]
0.0.0.0: Host key verification failed.

Strange, let's try to figure it out.

@bokket
Copy link
Member Author

bokket commented Aug 31, 2021

Starting namenodes on [localhost]
localhost: Host key verification failed.
localhost: Host key verification failed.
Starting secondary namenodes [0.0.0.0]
0.0.0.0: Host key verification failed.

Strange, let's try to figure it out.

I conducted experiments in my own warehouse and found a very interesting problem:
The version of "2.10.1" always seems to reject connection.

@Xuanwo
Copy link
Contributor

Xuanwo commented Aug 31, 2021

Great work!

@Xuanwo Xuanwo merged commit da4b69d into beyondstorage:master Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants