This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
Add gcs SSE-KMS support #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Apr 25, 2021
service.toml
Outdated
|
|
||
| [pairs.encryption_key] | ||
| type = "byte_array" | ||
| description = "is the customer's 32-byte AES-256 key" | ||
|
|
||
| [pairs.kms_key_name] | ||
| type = "string" | ||
| description = "is the Cloud KMS key resource. For example, projects/my-pet-project/locations/us-east1/keyRings/my-key-ring/cryptoKeys/my-key." |
There was a problem hiding this comment.
Maybe we could attach the docs link here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually gcs's SSE-KMS support encrypt an individual object with a Cloud KMS key (It's a parameter, not a header 👀). I added it.