Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

feat: Implement integration test #16

Merged
merged 29 commits into from
Aug 12, 2021
Merged

feat: Implement integration test #16

merged 29 commits into from
Aug 12, 2021

Conversation

npofsi
Copy link
Contributor

@npofsi npofsi commented Aug 8, 2021

No description provided.

.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
tests/utils_test.go Outdated Show resolved Hide resolved
utils.go Outdated Show resolved Hide resolved
storage.go Outdated Show resolved Hide resolved
storage.go Outdated
if err != nil {
return nil, err
}
for i := range flst {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide more information about this?

  • Which error message could be returned if we try to list a file?

According the code from fclairamb/ftpserverlib, it supports stat file:

https://github.com/fclairamb/ftpserverlib/blob/53cb37b53a67afc0c3cff1adada56b35568275f6/handle_files.go#L416-L450

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I found ftpserverlib support stat a file: https://sourcegraph.com/github.com/fclairamb/ftpserverlib@53cb37b53a67afc0c3cff1adada56b35568275f6/-/blob/handle_misc.go?L54:35

And the behavior is allowed in spec:

STATUS (STAT)

            This command shall cause a status response to be sent over
            the control connection in the form of a reply.  The command
            may be sent during a file transfer (along with the Telnet IP
            and Synch signals--see the Section on FTP Commands) in which
            case the server will respond with the status of the
            operation in progress, or it may be sent between file
            transfers.  In the latter case, the command may have an
            argument field.  If the argument is a pathname, the command
            is analogous to the "list" command except that data shall be
            transferred over the control connection.  If a partial
            pathname is given, the server may respond with a list of
            file names or attributes associated with that specification.
            If no argument is given, the server should return general
            status information about the server FTP process.  This
            should include current values of all transfer parameters and
            the status of connections.

@npofsi
Copy link
Contributor Author

npofsi commented Aug 9, 2021

Remove code that are used to fix bugs but irrelated to integration test.
It is normal that integration test runs failure after this commit.
I'll send a new PR to fix these bugs soon.

@Xuanwo Xuanwo merged commit f932d8b into beyondstorage:master Aug 12, 2021
@npofsi npofsi deleted the feature branch August 12, 2021 06:40
@Prnyself Prnyself mentioned this pull request Aug 16, 2021
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants