feat: Implement go-storage.Storager #13
Conversation
Xuanwo
changed the title
This reverts commit e8d82eb.
|
Please also remove We can reach it via: git rm --cached .vscode/ |
| require ( | ||
| github.com/beyondstorage/go-integration-test/v4 v4.2.0 | ||
| github.com/beyondstorage/go-storage/v4 v4.4.0 | ||
| github.com/jlaffaye/ftp v0.0.0-20210307004419-5d4190119067 |
There was a problem hiding this comment.
Let's better to depend on release version instead of git version, tracked at jlaffaye/ftp#175
| @@ -9,7 +10,7 @@ optional = ["object_mode"] | |||
| optional = ["object_mode"] | |||
|
|
|||
| [namespace.storage.op.list] | |||
| optional = ["list_mode"] | |||
| optional = ["list_mode","continuation_token"] | |||
There was a problem hiding this comment.
continuation_token support is optional, we can implement it in later PRs.
There was a problem hiding this comment.
Maybe ftp is not need token, just account?
There was a problem hiding this comment.
It can be used to list partially.
There was a problem hiding this comment.
It can be used to list partially.
continuation_token is used to resume a List operation.
There was a problem hiding this comment.
Since ftp server has not its native token, now, the token is the records of index in iterator.
| @@ -9,7 +10,7 @@ optional = ["object_mode"] | |||
| optional = ["object_mode"] | |||
|
|
|||
| [namespace.storage.op.list] | |||
| optional = ["list_mode"] | |||
| optional = ["list_mode","continuation_token"] | |||
There was a problem hiding this comment.
It can be used to list partially.
continuation_token is used to resume a List operation.
- Remove unused code - Change HTTP to TCP - Change import format
|
It now looks good to me, ping @Xuanwo for another review. |
No description provided.