Skip to content
This repository has been archived by the owner on Oct 18, 2021. It is now read-only.

ci: add diff check action #37

Merged
merged 2 commits into from
Jul 14, 2021
Merged

ci: add diff check action #37

merged 2 commits into from
Jul 14, 2021

Conversation

burntcarrot
Copy link
Member

Added a generate diff check for go-service-azblob.

Related: #525.

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 14, 2021

Let‘s rename the file name to diff-check.yml to keep the same naming style.

@@ -0,0 +1,23 @@
name: "diff_check"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Diff Check here to keep the same naming style.


jobs:
diff_check:
name: diff_check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@burntcarrot
Copy link
Member Author

Noted.

Just for a sanity check, can you inspect the git diff command? Is this what the expected behavior is supposed to be or do you need any modifications in the git diff command?

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 14, 2021

Just for a sanity check, can you inspect the git diff command? Is this what the expected behavior is supposed to be or do you need any modifications in the git diff command?

LGTM without any modifications

@Xuanwo Xuanwo merged commit 937b1ce into beyondstorage:master Jul 14, 2021
@burntcarrot
Copy link
Member Author

I'll move ahead with the same changes across all services! 😀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants