This repository has been archived by the owner on Oct 18, 2021. It is now read-only.
Implement commitAppend #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Apr 27, 2021
service.toml
Outdated
|
|
||
| [namespace.storage.op.stat] | ||
| optional = ["encryption_key", "encryption_scope"] | ||
|
|
||
| [pairs.access_tier] | ||
| type = "string" | ||
|
|
||
| [pairs.append_total_size_maximum] | ||
| type = "int64" | ||
| description = "max append total size in append operation" |
There was a problem hiding this comment.
append_total_size_maximum is provided by service instead of user, so there should not be a pair for it.
storage.go
Outdated
| @@ -306,6 +310,14 @@ func (s *Storage) writeAppend(ctx context.Context, o *Object, r io.Reader, size | |||
| accessConditions.AppendPositionAccessConditions.IfAppendPositionEqual = offset | |||
| } | |||
|
|
|||
| if opt.HasAppendTotalSizeMaximum { | |||
| if opt.AppendTotalSizeMaximum > 0 { | |||
There was a problem hiding this comment.
AppendTotalSizeMaximum should a const that defined in our code with azblob's documents link.
Xuanwo
approved these changes
Apr 29, 2021
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement commitAppend in ref: beyondstorage/go-storage#529.