Add appender support #18
Conversation
|
Please rebase to master and don't include unrelated commits. |
storage.go
Outdated
| } | ||
| _, err = s.bucket.NewAppendBlobURL(rp).Create(ctx, azblob.BlobHTTPHeaders{}, nil, | ||
| azblob.BlobAccessConditions{}, nil, cpk) | ||
|
|
There was a problem hiding this comment.
Please remove this empty line
storage.go
Outdated
| appendResp, err := s.bucket.NewAppendBlobURL(rp).AppendBlock( | ||
| ctx, iowrap.SizedReadSeekCloser(r, size), | ||
| azblob.AppendBlobAccessConditions{}, nil, cpk) | ||
|
|
| if err != nil { | ||
| return | ||
| } | ||
| offset += size |
There was a problem hiding this comment.
https://docs.microsoft.com/en-us/rest/api/storageservices/append-block
Maybe we don't need to update offset again here?
There was a problem hiding this comment.
func (s *aztestsSuite) TestAppendBlock(c *chk.C) {
bsu := getBSU()
container, _ := createNewContainer(c, bsu)
defer delContainer(c, container)
blob := container.NewAppendBlobURL(generateBlobName())
resp, err := blob.Create(context.Background(), BlobHTTPHeaders{}, nil, BlobAccessConditions{}, nil, ClientProvidedKeyOptions{})
c.Assert(err, chk.IsNil)
c.Assert(resp.StatusCode(), chk.Equals, 201)
appendResp, err := blob.AppendBlock(context.Background(), getReaderToRandomBytes(1024), AppendBlobAccessConditions{}, nil, ClientProvidedKeyOptions{})
c.Assert(err, chk.IsNil)
c.Assert(appendResp.Response().StatusCode, chk.Equals, 201)
c.Assert(appendResp.BlobAppendOffset(), chk.Equals, "0")
c.Assert(appendResp.BlobCommittedBlockCount(), chk.Equals, int32(1))
c.Assert(appendResp.ETag(), chk.Not(chk.Equals), ETagNone)
c.Assert(appendResp.LastModified().IsZero(), chk.Equals, false)
c.Assert(appendResp.ContentMD5(), chk.Not(chk.Equals), "")
c.Assert(appendResp.RequestID(), chk.Not(chk.Equals), "")
c.Assert(appendResp.Version(), chk.Not(chk.Equals), "")
c.Assert(appendResp.Date().IsZero(), chk.Equals, false)
appendResp, err = blob.AppendBlock(context.Background(), getReaderToRandomBytes(1024), AppendBlobAccessConditions{}, nil, ClientProvidedKeyOptions{})
c.Assert(err, chk.IsNil)
c.Assert(appendResp.BlobAppendOffset(), chk.Equals, "1024")
c.Assert(appendResp.BlobCommittedBlockCount(), chk.Equals, int32(2))
}From the test file in https://github.com/Azure/azure-storage-blob-go/blob/master/azblob/zt_url_append_blob_test.go, we can see that the appendResp.BlobAppendOffset() is not the next append position.
| } | ||
| } | ||
|
|
||
| appendResp, err := s.bucket.NewAppendBlobURL(rp).AppendBlock( |
There was a problem hiding this comment.
Maybe we need to set x-ms-blob-condition-appendpos to prevent the object has been appended via other process.
Optional conditional header, used only for the Append Block operation. A number indicating the byte offset to compare. Append Block will succeed only if the append position is equal to this number. If it is not, the request will fail with the AppendPositionConditionNotMet error (HTTP status code 412 – Precondition Failed).
https://docs.microsoft.com/en-us/rest/api/storageservices/append-block
JinnyYi
force-pushed
the
appender-support
branch
from
7c4a588 to
3b049b4
Compare
Add appender support in ref: beyondstorage/go-storage#529.