This repository has been archived by the owner on Oct 14, 2021. It is now read-only.
RFC-8: Add TCP protocol #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bokket <[email protected]>
Signed-off-by: bokket <[email protected]>
Xuanwo
reviewed
Jul 17, 2021
Signed-off-by: bokket <[email protected]>
Xuanwo
reviewed
Jul 17, 2021
docs/rfcs/8-add-tcp-protocol.md
Outdated
| ## Implementation | ||
|
|
||
| - Add protocol `tcp` | ||
| - Implement protocol tcp formatted (`func (p Endpoint) Tcp() (address string)`) |
There was a problem hiding this comment.
How about using TCP() as a function name instead of Tcp()? Keep the same style with HTTP() and HTTPS.
There was a problem hiding this comment.
And returning address string is not a good idea to me, how about returning (addr, host string, port int) instead?
docs/rfcs/8-add-tcp-protocol.md
Outdated
|
|
||
| - Add protocol `tcp` | ||
| - Implement protocol tcp formatted (`func (p Endpoint) Tcp() (address string)`) | ||
| - Implement protocol tcp parser (`func Parse(cfg string) (Provider, error)`) |
There was a problem hiding this comment.
I think Parse should return (p Endpoint, err error) instead.
docs/rfcs/8-add-tcp-protocol.md
Outdated
| - Add protocol `tcp` | ||
| - Implement protocol tcp formatted (`func (p Endpoint) Tcp() (address string)`) | ||
| - Implement protocol tcp parser (`func Parse(cfg string) (Provider, error)`) | ||
| - Implement protocol tcp object (`func NewTcp(address string) Endpoint `) |
There was a problem hiding this comment.
How about changing the API to NewTCP(host string, port int) Endpoint instead?
|
I will approve this proposal with reviewed changes. |
Xuanwo
reviewed
Jul 17, 2021
docs/rfcs/8-add-tcp-protocol.md
Outdated
| - RFC PR: [beyondstorage/go-endpoint#8](https://github.com/beyondstorage/go-endpoint/pull/8) | ||
| - Tracking Issue: [beyondstorage/go-endpoint/issues/9](https://github.com/beyondstorage/go-endpoint/issues/9) | ||
|
|
||
| # RFC-8: Add Tcp protocol |
There was a problem hiding this comment.
Suggested change
| # RFC-8: Add Tcp protocol | |
| # RFC-8: Add TCP protocol |
Signed-off-by: bokket <[email protected]>
Signed-off-by: bokket <[email protected]>
Xuanwo
reviewed
Jul 17, 2021
Xuanwo
approved these changes
Jul 17, 2021
|
Thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bokket [email protected]